Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sra i&a: add sigv4a and reorder operation phases #465

Merged
merged 1 commit into from
Nov 6, 2023
Merged

feat: sra i&a: add sigv4a and reorder operation phases #465

merged 1 commit into from
Nov 6, 2023

Conversation

lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Oct 27, 2023 •
edited
Loading

  • Add sigv4a auth definition
    • There's a temporary sigv4a "trait" which is used downstream, to be replaced by the real thing at the time it's added
  • Reorder operation phasing: auth resolution, identity retrieval, endpoint resolution, and signing now occur in that order at the beginning of the finalize phase
    • The operation input is now stored on the context at the beginning of serialize to be accessed as necessary by later phases
    • "resolve endpoint" middleware is now always generated and simply empty without a ruleset. A large number of components index off of it (both here and in the SDK downstream), better to have it be an "explicit" phase to not have to worry about it being there for stack operations
    • Path merging behavior now occurs as part of endpoint resolution, since that happens after serialization
  • Add anonymous identity and resolver
  • Give ConfigFieldResolver a new target for finalizing post-client creation (reverting the behavior of the old "finalize" to happen before client creation such that option modifications actually persist)

@lucix-aws lucix-aws requested review from a team as code owners October 27, 2023 16:07
@lucix-aws lucix-aws force-pushed the feat-sraauth-sigv4a branch from 615ac63 to f234157 Compare October 30, 2023 19:37
syall
syall approved these changes Nov 3, 2023
View reviewed changes
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/auth/SigV4aTrait.java
/**
* Fake trait for aws.auth#sigv4a until smithy adds it.
*/
public final class SigV4aTrait extends AbstractTrait {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mark as @SmithyInternalApi

@lucix-aws lucix-aws merged commit 9d77a17 into feat-sraauth Nov 6, 2023
1 check passed
@lucix-aws lucix-aws deleted the feat-sraauth-sigv4a branch November 6, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syall syall syall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucix-aws @syall